You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describe the changes
See title. You put LabAPI plugin in plugins folder, and it enables like exiled plugin
What is the current behavior? (You can also link to an open issue here)
Exiled would ignore the dll after seeing no types can be plugin
What is the new behavior? (if this is a feature change)
Exiled will check non-exiled plugins to see if they are LabAPI plugins then create them if so
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No?
Other information:
Very headachy, plz test this PR yourself with all the LabAPI plugins you can think of, also idk base Exiled loader behavior (which I wanted to mimic) so double check yaml errors get handled the same (like if yaml fails to parse config, we just reset the config to defaults right?)
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentations
Submission checklist
I have checked the project can be compiled
I have tested my changes and it worked as expected
Patches (if there are any changes related to Harmony patches)
I have checked no IL patching errors in the console
That only loads those methods into LabAPI's lists and hashsets etc... which is useless after LabAPI has loaded every plugin, the EnablePlugins / EnablePlugin methods also call Plugin::LoadConfigs which call a LabAPI extension method which checks for the configs in LabAPI's configs, which kinda defeats the purpose of this PR. Now it's not like I didn't see those methods, I just basically copy pasted what I needed from them and filled in the gaps. Also the PluginLoader class doesn't even have a method to disable plugins
/// <remarks>I love it when the modding framework people call the best has all plugin loading methods private and the config loading methods don't take custom directory paths.</remarks>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes
See title. You put LabAPI plugin in plugins folder, and it enables like exiled plugin
What is the current behavior? (You can also link to an open issue here)
Exiled would ignore the dll after seeing no types can be plugin
What is the new behavior? (if this is a feature change)
Exiled will check non-exiled plugins to see if they are LabAPI plugins then create them if so
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No?
Other information:
Very headachy, plz test this PR yourself with all the LabAPI plugins you can think of, also idk base Exiled loader behavior (which I wanted to mimic) so double check yaml errors get handled the same (like if yaml fails to parse config, we just reset the config to defaults right?)
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other