-
Notifications
You must be signed in to change notification settings - Fork 104
feat: added customroles get command #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…ommandSender check
Someone-193
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need some more changes, but a good step in the right direction! Make sure to revert your changes to the .csproj!
Someone-193
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I'll test it myself soon, idk if Yamato wants to get rid of that weird delta in the csproj but I personally don't care
|
I think it should be tested cuz I don't really remember but I suppose we can't cast |
but there a better way to make it i will push a commit |
VALERA771
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm but tests are required
| return false; | ||
| } | ||
|
|
||
| players.AddItem(player); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again iirc IEnumerable::AddItem returns new IEnumerable
Description
Describe the changes
Adds customroles get command which returns player current customrole (if any)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior? (if this is a feature change)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
Not compiled nor tested but this should work.
Types of changes
Submission checklist
Patches (if there are any changes related to Harmony patches)
Other