Skip to content

Conversation

@An4r3w
Copy link

@An4r3w An4r3w commented Oct 19, 2025

Description

Describe the changes
Adds customroles get command which returns player current customrole (if any)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
Not compiled nor tested but this should work.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

Copy link
Collaborator

@Someone-193 Someone-193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need some more changes, but a good step in the right direction! Make sure to revert your changes to the .csproj!

Copy link
Collaborator

@Someone-193 Someone-193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'll test it myself soon, idk if Yamato wants to get rid of that weird delta in the csproj but I personally don't care

@VALERA771
Copy link

I think it should be tested cuz I don't really remember but I suppose we can't cast ICommandSender to Player

@louis1706
Copy link

louis1706 commented Nov 5, 2025

I think it should be tested cuz I don't really remember but I suppose we can't cast ICommandSender to Player

when was last time you did use Exiled ? (you can) my bad i thinks it's used Player.Get not casting like you said bruh

but there a better way to make it i will push a commit

@louis1706 louis1706 linked an issue Nov 5, 2025 that may be closed by this pull request
Copy link

@VALERA771 VALERA771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but tests are required

return false;
}

players.AddItem(player);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again iirc IEnumerable::AddItem returns new IEnumerable

@VALERA771 VALERA771 added the Requires Testing Things need to be verified by an Exiled Developer/Contributor label Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CustomModules Requires Testing Things need to be verified by an Exiled Developer/Contributor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Command to get the custom roles of a player

4 participants