Repository navigation
fix(parser): read Unbound from the model and honor nodnsrebindcheck #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
intigenesis
wants to merge
13
commits into
EvilBit-Labs:main
Choose a base branch
from
intigenesis:fix/opnsense-unbound-general
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d55344e
fix(parser): read Unbound service state from the unboundplus model
intigenesis 73667bc
fix(plugins): fail FIREWALL-007 when DNS rebind checks are disabled
intigenesis d6ba058
docs(plugins): plain punctuation in the FIREWALL-007 text
intigenesis 3012a53
fix(plugins): stop failing STIG V-206690 on Unbound DNSSEC hardening
intigenesis c8aa063
test(parser): pin the Unbound store choice to the model version
intigenesis 95171f2
docs: correct the Unbound reading notes and FIREWALL-007 remediation
intigenesis f6d7ded
docs: record nodnsrebindcheck and the legacy Unbound reading
intigenesis c9a1eea
docs: align the V-206690 entry with the SNMP agent wording
intigenesis 22f39c9
docs: move the nodnsrebindcheck row beside the other system flags
intigenesis ee46206
refactor(parser): build the Unbound version set from one literal
intigenesis 5efed98
docs(plugins): share the hasUnnecessaryServices comment with the SNMP…
intigenesis 02cea2a
test(parser): pin the model dnssecstripped reading to 1
intigenesis 7f539b9
test(parser): pin the Unbound model version that does not parse
intigenesis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retain the SNMP community-string trigger.
hasUnnecessaryServicesininternal/plugins/stig/stig.gostill returns true whenSNMP.ROCommunityis non-empty. It does not check an agent-enable flag. A retained community string can therefore produce V-206690 even when the operator has disabled SNMP. The revised description no longer explains that result. Document the actual predicate while removing the obsolete Unbound condition. (raw.githubusercontent.com)As per path instructions, documentation must “Ensure clarity, accuracy, and completeness.”
Source: Path instructions