Skip to content

YouTube player for markdown #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 9, 2025
Merged

YouTube player for markdown #1291

merged 7 commits into from
Jun 9, 2025

Conversation

nikoshell
Copy link
Contributor

@nikoshell nikoshell commented Jun 5, 2025

New YouTube component which can be also used in any markdown content.
YT links are replaced with player.

@europython-society
Copy link
Member

europython-society commented Jun 5, 2025

Preview available

Key Value
url https://ep2025-yt.ep-preview.click
last update 2025-06-09T07:08:52.481Z

@nikoshell nikoshell requested a review from egeakman June 6, 2025 05:18
@nikoshell nikoshell self-assigned this Jun 6, 2025
@nikoshell nikoshell requested a review from clytaemnestra June 6, 2025 05:19
Copy link
Contributor

@clytaemnestra clytaemnestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please describe the problem this PR is addressing?

Never mind, I got it.

Copy link
Member

@egeakman egeakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Marcin!! One small question below:

astro.config.mjs Outdated
@@ -27,6 +27,8 @@ if (!gitVersion) {
}
}

const fastBuild = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this passable like --mode? It's fine to add it in another PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mode is astro argument, technically we can override it but there is no reason for that
I can do it as new flag.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah yeah, I meant as a new flag, similar to how we implemented --mode.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add it already as env variable EP_FAST_BUILD and set to true in dotenv for development.

@nikoshell nikoshell merged commit 7c3af8d into ep2025 Jun 9, 2025
6 checks passed
@nikoshell nikoshell deleted the ep2025-yt branch June 9, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants