-
Notifications
You must be signed in to change notification settings - Fork 64
YouTube player for markdown #1291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview available
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please describe the problem this PR is addressing?
Never mind, I got it.
Co-authored-by: Mia Bajić <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Marcin!! One small question below:
astro.config.mjs
Outdated
@@ -27,6 +27,8 @@ if (!gitVersion) { | |||
} | |||
} | |||
|
|||
const fastBuild = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this passable like --mode
? It's fine to add it in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mode is astro argument, technically we can override it but there is no reason for that
I can do it as new flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah yeah, I meant as a new flag, similar to how we implemented --mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I add it already as env variable EP_FAST_BUILD and set to true
in dotenv for development.
New YouTube component which can be also used in any markdown content.
YT links are replaced with player.