-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/keyword rank #4
base: master
Are you sure you want to change the base?
Conversation
Bad testing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tegkhanna Thanks!
This is a good addition.
Please make the required changes.
i = 1 | ||
rank = 1 | ||
try: | ||
while(i < 500): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not keep it as i<=100 and increment i by 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docid set has the same docid reoccurring 5 times.. that's why incrementing the count by 5. Multiplying was somehow offsetting the result. Will look into this though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay.
rank = rank + 1 | ||
except: | ||
return 0 | ||
return 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's return None
instead of 0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shall be done!
@@ -111,3 +112,27 @@ def title(self): | |||
selector = CSSSelector('.id-app-title') | |||
match = self.tree.xpath(selector.path) | |||
return match[0].text | |||
|
|||
def keyword_rank(self, search): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move this to a new file playstat.py
just like appstat.py
because this is not related to a particular app but is a general stat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, as a seperate research tool i guess! Optimisation websites offer this simple function for over 50$/month !
added keyword rank(when searched in playstore) for entered query. Feature often needed by developers for search optimization.
Needed the feature for myself so I thought why not to push it to the original repo as well!