Skip to content
This repository has been archived by the owner on Mar 4, 2023. It is now read-only.

Redo Economy page #23

Closed
wants to merge 9 commits into from
Closed

Conversation

osfanbuff63
Copy link

This is based off of #10. That pull request is very outdated, therefore I've taken it upon myself to redo it.

Bulk of the changes here, but not done on the shops section yet.
Copy link
Member

@mdcfe mdcfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start so far! I've left a few comments and suggestions that should hopefully make things a bit clearer and more accurate.

Economy.md Outdated
@@ -0,0 +1,89 @@
# EssentialsX Economy
EssentialsX comes with a simple, easy-to-use economy system. The built in economy API will redirect to any other detected economy system such as vault. This means you can use EssentialsX Economy as a economy API instead of Vault if your plugin is dependent on EssentialsX.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
EssentialsX comes with a simple, easy-to-use economy system. The built in economy API will redirect to any other detected economy system such as vault. This means you can use EssentialsX Economy as a economy API instead of Vault if your plugin is dependent on EssentialsX.
EssentialsX comes with a simple, easy-to-use economy system. The built-in economy API will redirect to any other detected economy system such as Vault. This means you can use EssentialsX Economy as a economy API instead of Vault if your plugin is dependent on EssentialsX.

IMO the economy API doesn't belong in the opening paragraph. The first paragraph should ideally explain EssentialsX's economy to server admins, but the economy API is only useful for plugin developers. We could have a separate section about Vault and plugin developers further down.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I forgot to move that :P

Economy.md Outdated Show resolved Hide resolved
Economy.md Outdated Show resolved Hide resolved
Economy.md Outdated Show resolved Hide resolved
Economy.md Outdated Show resolved Hide resolved
Economy.md Outdated Show resolved Hide resolved
@osfanbuff63 osfanbuff63 marked this pull request as ready for review March 17, 2022 19:36
@osfanbuff63
Copy link
Author

casually forgets to mention that this would resolve #1

@osfanbuff63
Copy link
Author

I think this is ready for review now, but I'm on vacation right now, I'll take a better look at it when I am back :D

## Signs
Signs may be used to create shops where players can buy and sell items/blocks to and from the server in exchange for in-game money. Most economy commands can be used on signs, such as `[Buy]`, `[Sell]`, or `[Trade]`. You can find an in-depth tutorial at [the original Essentials wiki](https://wiki.mc-ess.net/wiki/Sign_Tutorial).

## For plugin developers
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better if this was split into a separate page (as #1 (comment) says)?

@mdcfe
Copy link
Member

mdcfe commented Oct 31, 2022

Hey there! Apologies for not reviewing this sooner - things have been very busy over the past few months. Overall I'm happy with the content on this page. However, we're in the process of deprecating this repository in favour of https://github.com/EssentialsX/Website. Would you be willing either to open a new PR to that repository? (The content from this repository has moved to the pages/wiki directory in that repo - you can create a new page at pages/wiki/Economy.md.)

@mdcfe mdcfe mentioned this pull request Oct 31, 2022
@osfanbuff63
Copy link
Author

Oh wow, I had completely forgotten about this PR lol! I'd be happy to do that, just might be a bit as I have some project branches to wrap up, but this shouldn't be too hard to do :P

@mdcfe
Copy link
Member

mdcfe commented Oct 31, 2022

No worries! Let us know if you need a hand with it.

osfanbuff63 added a commit to osfanbuff63/EssX-Website that referenced this pull request Jan 12, 2023
Successor to EssentialsX/Wiki#23 - currently just a copy/paste from that PR so that I don't forget haha
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants