-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
Bulk of the changes here, but not done on the shops section yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start so far! I've left a few comments and suggestions that should hopefully make things a bit clearer and more accurate.
Economy.md
Outdated
@@ -0,0 +1,89 @@ | |||
# EssentialsX Economy | |||
EssentialsX comes with a simple, easy-to-use economy system. The built in economy API will redirect to any other detected economy system such as vault. This means you can use EssentialsX Economy as a economy API instead of Vault if your plugin is dependent on EssentialsX. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EssentialsX comes with a simple, easy-to-use economy system. The built in economy API will redirect to any other detected economy system such as vault. This means you can use EssentialsX Economy as a economy API instead of Vault if your plugin is dependent on EssentialsX. | |
EssentialsX comes with a simple, easy-to-use economy system. The built-in economy API will redirect to any other detected economy system such as Vault. This means you can use EssentialsX Economy as a economy API instead of Vault if your plugin is dependent on EssentialsX. |
IMO the economy API doesn't belong in the opening paragraph. The first paragraph should ideally explain EssentialsX's economy to server admins, but the economy API is only useful for plugin developers. We could have a separate section about Vault and plugin developers further down.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I forgot to move that :P
casually forgets to mention that this would resolve #1 |
I think this is ready for review now, but I'm on vacation right now, I'll take a better look at it when I am back :D |
## Signs | ||
Signs may be used to create shops where players can buy and sell items/blocks to and from the server in exchange for in-game money. Most economy commands can be used on signs, such as `[Buy]`, `[Sell]`, or `[Trade]`. You can find an in-depth tutorial at [the original Essentials wiki](https://wiki.mc-ess.net/wiki/Sign_Tutorial). | ||
|
||
## For plugin developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better if this was split into a separate page (as #1 (comment) says)?
Hey there! Apologies for not reviewing this sooner - things have been very busy over the past few months. Overall I'm happy with the content on this page. However, we're in the process of deprecating this repository in favour of https://github.com/EssentialsX/Website. Would you be willing either to open a new PR to that repository? (The content from this repository has moved to the |
Oh wow, I had completely forgotten about this PR lol! I'd be happy to do that, just might be a bit as I have some project branches to wrap up, but this shouldn't be too hard to do :P |
No worries! Let us know if you need a hand with it. |
Successor to EssentialsX/Wiki#23 - currently just a copy/paste from that PR so that I don't forget haha
This is based off of #10. That pull request is very outdated, therefore I've taken it upon myself to redo it.