Skip to content

Conversation

@mdcfe
Copy link
Member

@mdcfe mdcfe commented Aug 12, 2021

Information

This PR does not close an open issue.

Details

Proposed feature:
Use Paper's async command send API to filter commands out of Brigadier command suggestions.

Environments tested: (TODO)

OS:

Java version:

  • Most recent Paper version (1.XX.Y, git-Paper-BUILD)
  • CraftBukkit/Spigot/Paper 1.12.2
  • CraftBukkit 1.8.8

@mdcfe mdcfe added this to the 2.19.1 milestone Aug 12, 2021
# Conflicts:
#	Essentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java
@JRoy JRoy added module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests. labels Aug 12, 2021
@JRoy JRoy marked this pull request as ready for review September 15, 2021 21:12
@JRoy
Copy link
Member

JRoy commented Sep 15, 2021

Tested on the following versions to work as expected:
Paper 1.17.1
Spigot 1.17.1
Paper 1.13.2

@JRoy JRoy changed the title Use Paper async event to filter commands when available Asynchronously filter commands on Paper when possible Sep 15, 2021
@JRoy JRoy merged commit f0da17b into 2.x Sep 15, 2021
@JRoy JRoy deleted the feature/paper-async-command-send branch September 15, 2021 21:23
ressidell pushed a commit to ressidell/Essentials that referenced this pull request Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: main Issues or PRs for the main Essentials module type: enhancement Features and feature requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants