Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hub-common): add optional filter ids to discussions ISearchChannels #1837

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

velveetachef
Copy link
Contributor

@velveetachef velveetachef commented Mar 20, 2025

affects: @esri/hub-common

Issue 12771

  1. Description: add optional filter ids to discussions ISearchChannels interface

  2. Instructions for testing:

  3. Closes Issues: # (if appropriate)

  4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  5. used semantic commit messages

  6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  7. updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

@velveetachef velveetachef force-pushed the f/12771-search-channel-ids branch from fcb93d4 to ff85399 Compare March 20, 2025 18:26
Copy link
Contributor

@brittneyjb brittneyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@velveetachef velveetachef merged commit b9c28e9 into master Mar 20, 2025
5 checks passed
@velveetachef velveetachef deleted the f/12771-search-channel-ids branch March 20, 2025 18:52
esri-dcdev-2 pushed a commit that referenced this pull request Mar 20, 2025
# @esri/hub-common [15.43.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2025-03-20)

### Features

* **hub-common:** add optional filter ids to discussions ISearchChannels ([#1837](#1837)) ([b9c28e9](b9c28e9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants