Skip to content

fix(ui): media gallery overlay color update #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

anu13297
Copy link
Contributor

@anu13297 anu13297 commented Apr 11, 2025

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

  • Updated bg overlay color to match the prod.
  • Calcite mode effects the overlay color.

Test URLs:

Calcite mode is not matching with the prod so as the overlay gradient. Calcite mode should be updated to dark on Europe page

Copy link

aem-code-sync bot commented Apr 11, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@anu13297 anu13297 requested review from jsavella and twhite313 April 11, 2025 13:17
@anu13297 anu13297 self-assigned this Apr 11, 2025
Copy link

aem-code-sync bot commented Apr 11, 2025

Page Scores Audits Google
📱 /en-us/about/about-esri/europe/overview Timeout Exceeded PSI
🖥️ /en-us/about/about-esri/europe/overview Timeout Exceeded PSI
📱 /en-us/about/about-esri/overview PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /en-us/about/about-esri/overview Timeout Exceeded PSI

Copy link
Collaborator

@twhite313 twhite313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. The --esri-ui-opacity80 is correct, not the inverse version.

@twhite313
Copy link
Collaborator

Confusion resolved. I was looking at page incorrectly authored. Fix should fix it, authoring needs to update the other instance on the homepage

@anu13297 anu13297 merged commit ec510af into main Apr 11, 2025
1 of 2 checks passed
@anu13297 anu13297 deleted the mgoverlaycolor branch April 11, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants