feat: Implement KZG multiproof #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancharles92
changed the title
chancharles92
commented
Nov 10, 2023
ggutoski
reviewed
Nov 16, 2023
Comment on lines
476
to
481
| (evals_cm.into_group() - commitment.0.into_group()) | ||
| .into_affine() | ||
| .into(), | ||
| proof.proof.into(), | ||
| ]; | ||
| let pairing_inputs_r: Vec<E::G2Prepared> = vec![srs.h.into(), vanish_cm.into()]; |
There was a problem hiding this comment.
Lots of conversion here back-and-forth between affine and projective forms. Is all this conversion necessary?
|
@ggutoski ready for review again, the diff is below: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #387
Implement the KZG multiproof algorithm described in https://dankradfeist.de/ethereum/2020/06/16/kate-polynomial-commitments.html.
Since we assume that the number of opening points is small, we do not implement the fancy algorithm described in #387
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer