[Libp2p] Finish generic DHT persistence #2507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-maron
requested review from
philippecamacho,
ImJeremyHe,
sveitser,
jbearer,
tbro and
imabdulbasit
as code owners
imabdulbasit
reviewed
Mar 4, 2025
sequencer/src/persistence/sql.rs
Outdated
| bincode::serialize(&records).with_context(|| "failed to serialize records")?; | ||
|
|
||
| // Prepare the statement | ||
| let stmt = "UPSERT INTO libp2p_dht (id, serialized_records) VALUES (0, $1)"; |
There was a problem hiding this comment.
ah I meant upsert function on transaction.
something like this here
There was a problem hiding this comment.
Should be fixed now
imabdulbasit
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Finishes implementing generic DHT persistence now that HotShot is updated
What to look at: