Remove Nightly Dependency and Add Integration Tests #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esper89
requested changes
Mar 22, 2025
juniper-here
force-pushed
the
remove-nightly-dependency
branch
from
3745066 to
da2b037
Compare
Esper89
force-pushed
the
remove-nightly-dependency
branch
from
fb75927 to
24c8715
Compare
Esper89
force-pushed
the
remove-nightly-dependency
branch
from
24c8715 to
5b11768
Compare
Esper89
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
utf8_chunkshas been stabilized, I have removed the need for any nightly-only features, and updated the code to use the stabilized API.I have also added unit tests, following the examples in
README.md, to make sure the code indeed behaves as it should. Note for the last test, involving invalid UTF-8, I needed to use a smallunsafeblock, callingOsStr::from_encoded_bytes_unchecked, since Rust does not accept strings such as"\xFF".