Skip to content

Feat/acl fix#22

Open
hrothgar234567 wants to merge 8 commits intomasterfrom
feat/acl_fix
Open

Feat/acl fix#22
hrothgar234567 wants to merge 8 commits intomasterfrom
feat/acl_fix

Conversation

@hrothgar234567
Copy link
Collaborator

@hrothgar234567 hrothgar234567 commented Jul 21, 2025

Initial implementation of new ACL decompressor. The C++ library and C# support code have been provided. Currently, only transform tracks are handled. Scalar tracks are set to 0.

Summary of changes:

  • Removal of dependency of acldb_zzz.dll. Other bundled ACL DLLs are still required, though the goal is to move away from that dependency and centralize all decompression into a single library contained wholly within the repo.
  • Added new special cases to AnimationClip deserialization to ensure that the streamed data (i.e. database bulk data for high-fidelity animation data) is loaded for ZZZ.
  • Added a subclass of MHYACLClip for ZZZ ACL data.
  • Refactored signature of DecompressTracks to accept separate buffers for transform tracks, scalar tracks, db, and db bulk data.

TODO:

  • Additional validation that the implementation is working properly. I tested a few tracks and it seems to be, but it never hurts to be sure. Maybe we consult some of the animation folks from the Discord and give them a beta build?
  • Refactoring how the library is bundled with the application. Per the conversation we had, we probably want to include it in AnimeStudio.Libraries like the other ones.
  • Add support for scalar tracks.
  • Remove all other old ACL dependencies and centralize the behavior into the single library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants