-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename python tool to ipython for better tooluse format adherence #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 955afab in 13 seconds
More details
- Looked at
44
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. gptme/tools/__init__.py:79
- Draft comment:
The import statement should be updated to reflect the tool name change from 'python' to 'ipython'. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_s6YCea8pKD6G18RS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #361 +/- ##
==========================================
- Coverage 71.01% 70.99% -0.02%
==========================================
Files 68 68
Lines 5417 5417
==========================================
- Hits 3847 3846 -1
- Misses 1570 1571 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
955afab
to
113fa58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 113fa58 in 19 seconds
More details
- Looked at
52
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_v7TPTFwBBZoHjjRW
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
113fa58
to
a5a5984
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on a5a5984 in 13 seconds
More details
- Looked at
52
lines of code in3
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. gptme/tools/__init__.py:79
- Draft comment:
Update__all__
to reflect the tool name change frompython_tool
toipython_tool
for consistency and to avoid import issues. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_ETdeo2vvKY4EmoW6
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on fd8ea4d in 17 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. tests/test_cli.py:329
- Draft comment:
The test function nametest_python
should be updated totest_ipython
to reflect the change from 'python' to 'ipython'. This applies totest_python_error
as well. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_wWWar4Y7x73rkQ3W
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Lets give this a shot |
Attempt at improving #327
No idea if it actually performs better.
Important
Renames the 'python' tool to 'ipython' for better tool use format adherence, updating initialization and tests accordingly.
python
toipython
ingptme/tools/__init__.py
andgptme/tools/python.py
.init_tools()
to sort byipython
.test_tools_info()
intest_util_cli.py
to check foripython
instead ofpython
.test_subagent()
intest_cli.py
to useipython
in tool list.This description was created by for fd8ea4d. It will automatically update as commits are pushed.