Execute format check on CI pipeline

[matchilling]

No description provided.

[spacebaboon]

we want format:write, don't we?

[spacebaboon]

actually I'm not 100% sure what you're trying to do here. I'm busy right now, but maybe I can have a go at lunchtime. what we want, I think, is a pre-commit hook.

[spacebaboon]

https://prettier.io/docs/en/precommit.html

[matchilling]

I think it should be the contributor's responsibility to commit changes according to the repositories style guide. How they do it should be up to the individual.

Having that said, the purpose of this PR is just to enforce these rules through an additional check. Therefore I've added the yarn format:check cmd which will return a non-zero exit code if the commit is not aligned with the style guide.

[spacebaboon]

it's something extra to have to remember to do, or we can just make it part of the commit process. but I really don't mind in this case :)

…

On Fri, 17 Apr 2020 at 10:53, Mathias Schilling ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .travis.yml <#6 (comment)> : > @@ -5,7 +5,7 @@ node_js: - "10" deploy: provider: script - script: yarn install && yarn run deploy + script: yarn install && yarn format:check && yarn run deploy I think it should be the contributor's responsibility to commit changes according to the repositories style guide. How they do it should be up to the individual. Having that said, the purpose of this PR is just to enforce these rules through an additional check. Therefore I've added the yarn format:check cmd which will return a non-zero exit code if the commit is not aligned with the style guide. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#6 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFIN5DUCGJM22LILMQWPMTRNAKJ3ANCNFSM4MKR7LAA> .