fix: update dev setup docs and default env vars #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArendPeter
approved these changes
Jan 11, 2024
| @@ -97,7 +97,7 @@ Run these commands on your local machine: | |||
| git clone --depth=1 https://github.com/YOUR_USER_NAME/star-server.git | |||
| ``` | |||
|
|
|||
| This will download the entire freeCodeCamp repository to your projects directory. | |||
| npm run dev | ||
| ``` | ||
|
|
||
| Launch frontend | ||
| Launch frontend. If you want to just run the web client without setting up the server you can change the proxy under frontend/package.json to "proxy": "dev.star.vote". |
There was a problem hiding this comment.
Were you able to get the proxy to work?
I used to use this trick when we were on heroku, but I haven't had success with the dev.star.vote endpoint yet
There was a problem hiding this comment.
I didn't try it - assumed it was still working 😬
I was able to get it to look at other local port here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After completing onboarding, making some changes to doc to reflect current setup process. I made some assumptions here:
Related issues
#425