feat(opensidian): toolbar follow-ups — onboarding, factory fix, logo#1635
Merged
feat(opensidian): toolbar follow-ups — onboarding, factory fix, logo#1635
Conversation
Small logo icon in a rounded black square container, placed at the left of the sidebar header before the action icons.
…nd terminal When the file tree is empty on load, the app now automatically loads sample data, opens the README, opens the terminal panel, and prints a welcome message with example commands. The terminal is the killer feature for developers—hiding it behind a keyboard shortcut means most visitors would never discover it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1632. That PR deleted the toolbar and redistributed actions. This one fixes what we got wrong and adds first-visit onboarding for the HN launch.
The terminal is the feature that makes opensidian different from every other notes app—but it was completely hidden behind ⌘`. A HN visitor would land on an empty file tree, see "No file selected", and leave. Now, first-time visitors get three things simultaneously: sample data populates the file tree, the README opens in the editor, and the terminal opens with a welcome message:
No modal, no tour, no signup wall. Just a terminal with a blinking cursor that a developer immediately understands.
The sample data loader was hitting Svelte's `state_invalid_export` because it exported a bare `$state` that gets reassigned. The first workaround (a standalone `isSeeding()` function) broke the codebase convention where every `.svelte.ts` state module uses a factory. Reverted to a proper `createSampleDataLoader()` factory with the `$state` inside a closure exposed through a getter.
The "FILES" label in the sidebar header was dead weight—icons already communicate context. Removed. The Epicenter logo now sits at the left of the sidebar header in a `bg-black` rounded container so the gray+white circles stay visible on any background.
Stacks on #1632.