Open
Conversation
- Add sound.selectedSound.<event> settings for all 8 events - Add sound registry (SoundId, bundled metadata, getDefaultBundledSoundId) - Extend PlaySoundService with listAvailableSounds, getSoundUrl - Implement OS system sounds via Tauri list_system_sounds (macOS/Windows/Linux) - Resolve selected sound at playback with fallback to default bundled - Query layer: pass selectedSoundId to playSound, add listAvailableSounds and previewSound Made-with: Cursor
- Per-event sound dropdown (bundled + system sounds on desktop) - Preview button to play selected sound - Grouped by Manual, VAD, and Completion sounds Made-with: Cursor
ecodan
force-pushed
the
initiative/sound-customization
branch
from
94a159a to
da20258
Compare
Author
|
Branch merged with recent config changes. Pls consider approving this fork for additional sound options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a comprehensive sound customization system to Whispering. It allows users to choose different sounds for specific application events (like starting/finishing a recording) and supports both bundled audio files and native OS system sounds on the desktop.
Type of Change
feat: New featurefix: Bug fixdocs: Documentation updaterefactor: Code refactoring (no functional changes)perf: Performance improvementtest: Test additions or changeschore: Maintenance tasksstyle: Code style changesRelated Issue
Closes #
Changes Made
.mp3assets and native system sounds (viasystem_sounds.rsbridge).soundservice to handle logic across Svelte (web) and Tauri (desktop) consistently.Testing
Desktop App Testing
General Testing
Checklist
typeinstead ofinterfacein TypeScriptScreenshots/Recordings
Additional Notes
The sound system is designed to be extensible, making it easy to add more event types or sound sources in the future.