fix(groq): surface non-APIError fetch failures as WhisperingError#1377
Open
aspiers wants to merge 1 commit intoEpicenterHQ:mainfrom
Open
fix(groq): surface non-APIError fetch failures as WhisperingError#1377aspiers wants to merge 1 commit intoEpicenterHQ:mainfrom
aspiers wants to merge 1 commit intoEpicenterHQ:mainfrom
Conversation
Previously, if the Groq SDK's fetch call threw anything other than a Groq.APIError (e.g. a network error or IPC failure from tauriFetch), the catch handler would re-throw it. This escaped the tryAsync wrapper and caused an unhandled promise rejection, silently killing the transcription pipeline with no user-visible error. Now all non-APIError throws are caught and returned as a WhisperingErr with the error message extracted, so they surface as toast notifications like any other transcription failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a Groq transcription request fails with a non-
APIError(e.g. a network error ortauriFetchfailure), the previous code re-threw the error as an unhandled exception rather than returning a user-facing error.This fix catches non-
APIErrorexceptions and wraps them in aWhisperingErrwith a descriptive title and message, consistent with how other errors are handled in this service.