Specify max file size per-transcription service#1245
Open
rgoldfinger wants to merge 2 commits intoEpicenterHQ:mainfrom
Open
Specify max file size per-transcription service#1245rgoldfinger wants to merge 2 commits intoEpicenterHQ:mainfrom
rgoldfinger wants to merge 2 commits intoEpicenterHQ:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
feat: New featurefix: Bug fixdocs: Documentation updaterefactor: Code refactoring (no functional changes)perf: Performance improvementtest: Test additions or changeschore: Maintenance tasksstyle: Code style changesRelated Issue
Closes #786
Changes Made
Specify file size limits per-transcription service. The file upload control already enforces the passed-in file size limit so this was a surprisingly small change to make.
Testing
I have tested this locally with a 100mb file using local whisper.
Desktop App Testing
General Testing
Checklist
typeinstead ofinterfacein TypeScriptScreenshots/Recordings
Additional Notes