fix(whispering): Allow opener to access files in data directory on Linux#1201
Open
Wartijn wants to merge 1 commit intoEpicenterHQ:mainfrom
Open
fix(whispering): Allow opener to access files in data directory on Linux#1201Wartijn wants to merge 1 commit intoEpicenterHQ:mainfrom
Wartijn wants to merge 1 commit intoEpicenterHQ:mainfrom
Conversation
Explicitly allow opener to open paths in data directory, so the default directories for recordings and transformations can be opened on Linux. If opening a folder throws a string as an error, add that string to the notification that is sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add paths of the data directories to the permissions of
opener:allow-open-path. For Linux the wildcard path can't be used for this, so without this change, the default directories for recordings and transformations can't be opened via the buttons that useplugin-opener.Type of Change
feat: New featurefix: Bug fixdocs: Documentation updaterefactor: Code refactoring (no functional changes)perf: Performance improvementtest: Test additions or changeschore: Maintenance tasksstyle: Code style changesRelated Issue
Closes #1200
Changes Made
opener:allow-open-pathas described above. This is the same fix as feat(linux): add explicit file system permissions for app data directory #866, but foropener:allow-open-pathinstead offs:scopeTesting
For both the error handling and permission fix I tested this in these places:
Before fixing the permissions, clicking any of the buttons would show a notification showing "Not allowed to open path".
After fixing the permissions, clicking the button opens the default file explorer.
As for the checks below:
Desktop App Testing
General Testing
Checklist
typeinstead ofinterfacein TypeScriptScreenshots/Recordings
Additional Notes