Bump headless_chrome #15
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build was failing with the newer versions of headless_chrome because of changes to the PrinttoPdfOptions struct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build was failing with the newer versions of headless_chrome because of changes to the PrintToPdfOptions struct. This is causing the
cargo install htopcommand to fail since the cargo dependency ofheadless_chrome = "1.0.15"is equivalent toheadless_chrome = "^1.0.15"and is therefore fulfilled by default by the latest version of headless_chrome (of1.0.17) despite its breaking change.This PR bumps the version of
headless_chrometo the latest and resolves the breaking change.