Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set global *warn-on-reflection* = true #192

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexei-matveev
Copy link
Contributor

Now that Instaparse is reflection-free maybe consider adding this flag?

https://clojuredocs.org/clojure.core/*warn-on-reflection*

I am not quite sure how far the side effects can go.

@Engelberg
Copy link
Owner

I guess the question is whether this would set the flag for all projects using instaparse, or only when you start the repl in the environment created by this particular project.clj file. I don't know the answer to that offhand.

I used to keep the warn-on-reflection flag set in my own personal profiles.clj, so it was easy to catch issues in instaparse as I developed a tested it, but many other libraries I used generated lots of warnings, which got annoying so I turned it off. I intended to turn it back on before testing and pushing each build, but it looks like I forgot to do so for 1.9.

@alexei-matveev
Copy link
Contributor Author

Yes, not clear what is better. BTW, you can build native binaries from Instaparse.
Just tried this:

https://github.com/alexei-matveev/instaparse-demo

@Engelberg
Copy link
Owner

That's exciting work! I haven't had the opportunity to do much with graal, but it's amazing to see it in action. What did you have to install to be able to build the native-image?

@alexei-matveev
Copy link
Contributor Author

Only GraalVM which is another JDK of ~250M compresse, https://github.com/oracle/graal/releases

The compiler is in the bin/ subdir of the archive. It is still not quite ready for the prime time though. I updated the README too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants