Skip to content

Conversation

@lugehorsam
Copy link
Contributor

  • Fix error-handling in trap {} statement by changing it to a try...catch
    • If the script hit an error before $repoRootDir = Get-Location was invoked, the error would get masked by another error from within the trap handler
- InvalidOperation: C:\Users\lgehorsam\example\platform\windows_x64\docker\build.ps1:28:16
Line |
  28 |    Set-Location $repoRootDir
     |                 ~~~~~~~~~~~~
     | The variable '$repoRootDir' cannot be retrieved because it has not been set.
  • Remove reference to previous windows container image.
  • Fix repository root path test
  • Change URI where build tools are pulled from.

],
exec_properties = {
"container-image": "docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-re/windows-x64:engflow_worker@sha256:6a53c6d5cbc82ca0782e9117482e457a676920227b697de5db90ff53e7afedbe",
"container-image": "<YOUR_WINDOWS_CONTAINER_IMAGE_URI>",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this because of security reasons?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait. It looks like we don't run against windows (I think we did before)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this: it's not an example, it's meant to be used in production, even if we're not doing that right now.

],
exec_properties = {
"container-image": "docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-re/windows-x64:engflow_worker@sha256:6a53c6d5cbc82ca0782e9117482e457a676920227b697de5db90ff53e7afedbe",
"container-image": "<YOUR_WINDOWS_CONTAINER_IMAGE_URI>",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep this: it's not an example, it's meant to be used in production, even if we're not doing that right now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is based on an internal script docker_build.ps1. Let's keep these in sync. Please update that one first and verify docker build works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants