Skip to content

Potential fix for code scanning alert no. 5: Incomplete string escaping or encoding #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheJACKedViking merged 1 commit into from
Dec 26, 2025
Merged

Potential fix for code scanning alert no. 5: Incomplete string escaping or encoding #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/middleware/timing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,9 @@ function formatTimingEntry(entry: ServerTimingEntry): string {
let result = entry.name;
result += `;dur=${entry.dur.toFixed(1)}`;
if (entry.desc) {
// Quote description if it contains special characters
result += `;desc="${entry.desc.replace(/"/g, '\\"')}"`;
// Quote and escape description for use in a HTTP quoted-string value
const escapedDesc = entry.desc.replace(/\\/g, '\\\\').replace(/"/g, '\\"');
result += `;desc="${escapedDesc}"`;
}
return result;
}
Expand Down
Loading