Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add filter keyword function to replace spaces with %20 #120

Merged

Conversation

takanome-dev
Copy link
Member

@takanome-dev takanome-dev commented Sep 2, 2022

I added filterKeyword.js in utils folder to filter all spaces in the keyword (/src/controller/api/twitterAPIController) and also a test file to make sure that it does work properly!

And all double quotes inside files that I opened are changed in single quote by prettier. Sorry about that 😓

Close #119

@takanome-dev
Copy link
Member Author

Seems like there is some issues with the actions.
@MizouziE am I missing some configurations to make the deployment pass or?
I found this interesting issue about the action.
Perhaps we need to add another step?
Let me know what do you think about it

@MizouziE
Copy link
Collaborator

MizouziE commented Sep 2, 2022

@takanome-dev Ah sorry! No it's my fault cos I was messing with other options for hosting and started playing with new CI/CD stuff. It's perfectly fine to ignore at the moment as it doesn't actually deploy anywhere. I have a solution in the pipeline that will be able to make use of the actions, so I didn't bother removing it as I'll just need to update it once my server is in place.

We'll soon be saying bye-bye to heroku! 🙌

Copy link
Collaborator

@MizouziE MizouziE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

src/server.js Show resolved Hide resolved
@MizouziE MizouziE merged commit a1dcc1a into Energy-Price-News-API:master Sep 2, 2022
@takanome-dev takanome-dev deleted the fix-spaces-in-keyword branch September 3, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Server crashes due to twitter searchs
2 participants