Skip to content

[dev] Bump ember-cli-deploy-revision-data #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kiwi-josh
Copy link

To resolve a critical dependabot vulnerability in simple-git
GHSA-9p95-fxvg-qgq2

@kiwi-josh
Copy link
Author

CC @Exelord 🙇

@kiwi-josh
Copy link
Author

@Exelord Any movement on this? 🙏

@Exelord
Copy link
Member

Exelord commented Oct 22, 2023

The Pr is not mergable :/

@ddoria921
Copy link

@Exelord I'm running into this same vulnerability mentioned above -- https://socket.dev/npm/package/ember-cli-deploy-sentry-cli/overview/3.1.0

Looking further at the source code it doesn't seem we need ember-cli-deploy-revision-data as an npm dependency. It could likely either be omitted or listed as a peerDependency. From looking at other addons that rely on it (like ember-cli-deploy-display-revisions) I don't seem them listing it as a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants