Subscription I/O #1308
Subscription I/O #1308
Conversation
|
Hmm, there seems to be a determinism issue in the |
|
I haven't yet tracked down the non-determinism bug in the test that was failing yet, so this still shouldn't be merged (or if it is, need to disable that test for now). |
XAMPPRocky
left a comment
XAMPPRocky
left a comment
There was a problem hiding this comment.
Some code clarity suggestions but looks good to me otherwise.
| if qcmp_port.is_none() && icao.is_none() { | ||
| return Ok(ExecResponse { | ||
| results: vec)) => { |
| match request { | ||
| proto::Request::V1(inner) => { | ||
| use proto::v1; | ||
|
|
||
| match inner { |
There was a problem hiding this comment.
similar here this match pattern could be collapsed.
There was a problem hiding this comment.
I also feel like a lot of the branches here should be factored out into separate functions.
Endpoint was using untagged serialization, which meant that serialization an AddressKind::Ip would get deserialized as an AddressKind::Name Adds tests for roundtripping to catch errors in the future, as well a parsing test
2 participants
This PR expands on #1296 and implements the actual I/O over a quic stream of subscribing and receiving events.
Ideally #1296 would be merged first so it's easier to review the changes unique to this PR over that one.