Code

ticket-booking code review#1

Code

Open

Elmacioro wants to merge 43 commits intoreviewElmacioro/ticket-booking:reviewfrom mainElmacioro/ticket-booking:mainCopy head branch name to clipboard

+3,170-2

Commits

Commits on Feb 24, 2023

• Added basic screening domain logic and jpa support

  Elmacioro

  committed
  725d5f6

  Copy full SHA for 725d5f6

Commits on Feb 25, 2023

• Added entities mapping, modified DTOs, finished screening part of domain

  Elmacioro

  committed
  6aa823d

  Copy full SHA for 6aa823d

• Removed a few unnecessary lombok annotations

  Elmacioro

  committed
  35f8d74

  Copy full SHA for 35f8d74

• Added lombok to EntityToDomainMapper

  Elmacioro

  committed
  1397527

  Copy full SHA for 1397527

• Fixed typo

  Elmacioro

  committed
  b0513c9

  Copy full SHA for b0513c9

Commits on Feb 26, 2023

• Added few domain unit tests

  Elmacioro

  committed
  5217170

  Copy full SHA for 5217170

• Added exception handling

  Elmacioro

  committed
  1230b38

  Copy full SHA for 1230b38

• Added database integration tests

  Elmacioro

  committed
  3e7931f

  Copy full SHA for 3e7931f

• Tidied up sql init data, added bash build script, added bash use case script

  Elmacioro

  committed
  1428ad9

  Copy full SHA for 1428ad9

• Titied up tests

  Elmacioro

  committed
  1f69fb7

  Copy full SHA for 1f69fb7

• Changed seats to list in Screening

  Elmacioro

  committed
  fea484d

  Copy full SHA for fea484d

Commits on Feb 27, 2023

• Added reservation functionality

  Elmacioro

  committed
  9d2e815

  Copy full SHA for 9d2e815

Commits on Feb 28, 2023

• Updated use case script

  Elmacioro

  committed
  61a73bb

  Copy full SHA for 61a73bb

• Fixed regexes for names

  Elmacioro

  committed
  56b4831

  Copy full SHA for 56b4831

• Seats can be booked 15 min before screening check added

  Elmacioro

  committed
  850caac

  Copy full SHA for 850caac

• Added booking check whether seat exists for given screening

  Elmacioro

  committed
  40be48e

  Copy full SHA for 40be48e

• Added domain to entities and entities to domain mappers

  Elmacioro

  committed
  0a1d75e

  Copy full SHA for 0a1d75e

• Added ticketType validity check, some refactoring

  Elmacioro

  committed
  9fa7966

  Copy full SHA for 9fa7966

• Refactored Movie screenings sorting

  Elmacioro

  committed
  b034c09

  Copy full SHA for b034c09

• Removed few tests

  Elmacioro

  committed
  3d5dd15

  Copy full SHA for 3d5dd15

Commits on Mar 1, 2023

• Added logging, refactored exceptions

  Elmacioro

  committed
  ffacc60

  Copy full SHA for ffacc60

• Added reservation tests

  Elmacioro

  committed
  f38fd0b

  Copy full SHA for f38fd0b

• Added readme

  Elmacioro

  committed
  ab6b679

  Copy full SHA for ab6b679

• Updated readme for github

  Elmacioro

  committed
  0918df0

  Copy full SHA for 0918df0

• Updated readme

  Elmacioro

  committed
  fc861b1

  Copy full SHA for fc861b1

Commits on Mar 2, 2023

• Moved private methods in test

  Elmacioro

  committed
  3c076c0

  Copy full SHA for 3c076c0

• Refactored ReservationManagement methods

  Elmacioro

  committed
  2c9c3c7

  Copy full SHA for 2c9c3c7

Commits on Mar 4, 2023

• Changed seatInRowNumber to seatNumber

  Elmacioro

  committed
  9723963

  Copy full SHA for 9723963

• Changed ticketTypeId from requests to ticketTypeName

  Elmacioro

  committed
  5c9e668

  Copy full SHA for 5c9e668

• Moved throwing NoSuchScreeningException to ScreeningDao

  Elmacioro

  committed
  0c7dfd1

  Copy full SHA for 0c7dfd1

• Refactored validation for booking seats

  Elmacioro

  committed
  bb90c87

  Copy full SHA for bb90c87

• Changed naming from free seats to available seats

  Elmacioro

  committed
  aaf2ea4

  Copy full SHA for aaf2ea4

• Changed response so only available seats are returned

  Elmacioro

  committed
  b92b053

  Copy full SHA for b92b053

• Added assumption that time interval can be at max 1 week

  Elmacioro

  committed
  321b6ce

  Copy full SHA for 321b6ce

• Clean up ReservationManagement

  Elmacioro

  committed
  247faaa

  Copy full SHA for 247faaa

Commits on Mar 5, 2023

• Splitted mapping and sorting in ScreeningManagement

  Elmacioro

  committed
  181db35

  Copy full SHA for 181db35

• Changed ids that user can see to UUIDs, refactored code

  Elmacioro

  committed
  2317f98

  Copy full SHA for 2317f98

• Added mappers tests

  Elmacioro

  committed
  8383712

  Copy full SHA for 8383712

• Added few missing NonNull checks

  Elmacioro

  committed
  3c14dbf

  Copy full SHA for 3c14dbf

• Added one additional assumption to readme

  Elmacioro

  committed
  5571b80

  Copy full SHA for 5571b80

• Removed useless comment

  Elmacioro

  committed
  e41c034

  Copy full SHA for e41c034

• Updated useCase and readme

  Elmacioro

  committed
  0d688a4

  Copy full SHA for 0d688a4

• Added empty line at the end of some files

  Elmacioro

  committed
  3508cb6

  Copy full SHA for 3508cb6