Skip to content

Feat/refactor-bcli #8820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dovgopoly wants to merge 10 commits into
base: master
Choose a base branch
from
+390 −705
Open

Feat/refactor-bcli #8820

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
598b984
bcli: add synchronous `run_bitcoin_cli` for future refactor
dovgopoly Jan 5, 2026
5138815
bcli: convert `getchaininfo` to synchronous execution
dovgopoly Jan 5, 2026
5b48c8a
bcli: convert `getutxout` to synchronous execution
dovgopoly Jan 5, 2026
5c65ab6
bcli: convert `sendrawtransaction` to synchronous execution
dovgopoly Jan 5, 2026
fa77e4b
bcli: convert `estimatefees` to synchronous execution
dovgopoly Jan 6, 2026
eb449e5
bcli: convert `getrawblockbyheight` to synchronous execution
dovgopoly Jan 8, 2026
57d5946
lightningd: add error checking for bcli plugin responses
dovgopoly Jan 9, 2026
8c0d9e5
pytest: fix bcli tests after sync refactor
dovgopoly Jan 9, 2026
ef431c4
bcli: remove unused async code after sync refactor
dovgopoly Jan 9, 2026
dddf995
bcli: return "not found" on any `getblockhash` exit status
dovgopoly Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions plugins/bcli.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,7 @@ static struct command_result *getrawblockbyheight(struct command *cmd,
tal_fmt(tmpctx, "%u", *height), NULL);

if (res->exitstatus != 0) {
/* Exit code 8 means block height doesn't exist (empty response) */
if (res->exitstatus == 8)
return getrawblockbyheight_notfound(cmd);
return command_err(cmd, res, "command failed");
return getrawblockbyheight_notfound(cmd);
Copy link
Collaborator Author

@dovgopoly dovgopoly Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think returning a null response should be alright. I don't see the case we need to return error here. We can return an empty block and try again later. Tests are waiting the same behavior.

}

strip_trailing_whitespace(res->output, res->output_len);
Expand Down
Loading