Skip to content

common: fix ubsan trigger in param test. #8815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustyrussell merged 1 commit into from
Jan 6, 2026
+10 −1
Merged

common: fix ubsan trigger in param test. #8815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion common/test/run-param.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,9 +376,18 @@ static void bad_programmer(void)
p_req("repeat", param_millionths, &fpval), NULL);
assert(paramcheck_assert_failed);

/* UBSan gets upset with doing arith on NULL pointers, inside
* the p_req macro, so we do it raw here */
#define p_req_raw(name, cbx, arg) \
name"", \
PARAM_REQUIRED, \
NULL, NULL, \
(param_cbx)(cbx), \
(arg)

paramcheck_assert_failed = false;
param(cmd, j->buffer, j->toks,
p_req("u64", (param_cbx) NULL, NULL), NULL);
p_req_raw("u64", NULL, NULL), NULL);
assert(paramcheck_assert_failed);

/* Add required param after optional */
Expand Down
Loading