fix: invalid link deletes message, so stop checking (#813)

* fix: invalid link deletes message, so stop checking * fix: onDelete handles cleanup, so no db work needed in OnUpdate
EddieHubCommunity · Jul 2, 2024 · 450dcf0 · 450dcf0
1 parent df216ec
commit 450dcf0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/events/onMessage.ts b/src/events/onMessage.ts
@@ -23,6 +23,7 @@ export const onMessage = async (bot: ExtendedClient, message: Message) => {
       await adminChannel.send({
         embeds: [linkMessage],
       });
+      return; // Return as message is deleted
     }
 
     const cleaned = await sentenceTypoFixer(

diff --git a/src/events/onUpdate.ts b/src/events/onUpdate.ts
@@ -31,7 +31,16 @@ export const onUpdate = async (
     return;
   }
 
-  await checkLinks(bot, newMessage);
+  const linkMessage = await checkLinks(bot, newMessage);
+  if (linkMessage) {
+    const adminChannel = bot.channels.cache.get(process.env.ADMIN_CHANNEL!);
+    if (adminChannel && adminChannel.isTextBased()) {
+      await adminChannel.send({
+        embeds: [linkMessage],
+      });
+    }
+    return; // Return as message is deleted
+  }
 
   // log to admin channel updates
   const oldContent = oldMessage.content;