[Logger] Small cleanup. Implement IDisposable.

Ebola16 · Jun 2, 2018 · de6d327 · de6d327
1 parent 569c209
commit de6d327
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/DolphinBisectTool/Backend.cs b/DolphinBisectTool/Backend.cs
@@ -101,6 +101,7 @@ public void Bisect(string boot_title = "")
             {
                 string sb = string.Join(", ", skipped_builds.ToArray());
                 log.Write("Skipped builds: " + sb);
+                log.Dispose();
             }
             UserInput open_url = BisectEvent(test_index, true);
 

diff --git a/DolphinBisectTool/Logger.cs b/DolphinBisectTool/Logger.cs
@@ -6,25 +6,34 @@
 
 namespace DolphinBisectTool
 {
-    class Logger
+    class Logger : IDisposable
     {
         StreamWriter log_file;
+        bool disposed = false;
+
 
         public Logger()
         {
             log_file = new StreamWriter("log-" + DateTime.Now.ToString("yyyy-MM-dd_hhmmss") + ".txt");
         }
 
-        ~Logger()
+        public void Dispose()
+        {
+            Dispose(true);
+            GC.SuppressFinalize(this);
+        }
+
+        protected virtual void Dispose(bool disposing)
         {
-            // TODO - figure out why closing the file here throws an exception.
-            try
+            if (disposed)
+                return;
+
+            if (disposing)
             {
                 log_file.Close();
             }
-            catch (Exception e)
-            {
-            }
+
+            disposed = true;
         }
 
         public void Write(string s)