Open
Conversation
Both function independently of one another, so if a game was released using either version it should work flawlessly.
Contributor
|
some stuff to consider /*
* This file is part of EasyRPG Player.
* ... (license header) ...
* Based on DynRPG Particle Effects V1 by Kazesui. (MIT license)
*/the generated code ignores the license code (my llm rigging of it had it removed to be economical, but it should be manually pasted) Other thing thing, does the v1 and v2 share or repeat code? |
Member
|
Does this code address the non-working fast forward support? When pressing "F" to speedup the Player the particles (e.g. in Deep8) kept the same speed (or even worse: On 120 Hz displays the particles were twice as fast than the rest of the game). This was this "nobody understands the code Kazesui wrote" issue where I couldn't figure out how to split the Update and Draw logic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both function independently of one another, so if a game was released using either version it should work flawlessly.