Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL: detect unsupported engines #3326

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Primekick
Copy link
Contributor

Some users, particularly on mobile, struggle to understand why EasyRPG doesn't detect any playable content when trying to run games made with unsupported engines like RPG Maker versions other than 2kX or similar software (e.g. Wolf RPG Editor).

This PR addresses this issue by implementing a feature that detects games created with commonly encountered unsupported engines. Affects both regular and Android version of the player. The list of known engines consists of:

  • RPG Maker XP
  • RPG Maker VX
  • RPG Maker VX Ace
  • RPG Maker MV/MZ
  • Wolf RPG Editor

A few screenshots demonstrating the feature:
Player_20250107-152146
image
image-1
image
image-1

@Ghabry
Copy link
Member

Ghabry commented Jan 7, 2025

Jenkins: test this please

Thanks! Looks good.

What could become a problem on mostly our console platforms is Show information for unsupported engines directly on the game list. Reason is that IO performance on many homebrew platforms is ridiculous slow, so fetching these information takes a while :/.

Have to benchmark how awful the performance penalty is.

@Ghabry Ghabry added this to the 0.8.1 milestone Jan 8, 2025
@Ghabry Ghabry self-requested a review January 9, 2025 14:22
@Ghabry
Copy link
Member

Ghabry commented Jan 10, 2025

also worth adding: RPG_RT.rs1. That's an encrypted archive format you can create via the latest Maniac Patch editor. Until somebody reverse engineers the encryption this will not run (even though it's technically a RPG Maker 2k3 game...)

@florianessl
Copy link
Member

I went & checked a few older RPG95 / SimRPG 95 games for identification.
These names should prove to be reliable targets for a simple file name check, if you'd like to include them:

  • SWNAME.DAT + *.RPG -> RPG Maker 95
  • SWNAME.DAT + GEOLOGY.DAT -> Sim RPG Maker 95

Comment on lines +359 to +370
*
* 2k v1.51 (Japanese) : 746496
* 2k v1.50 (Japanese) : 745984
* -- threshold (2k) -- : 735000
* 2k v1.10 (Japanese) : 726016
*
* 2k3 v1.09a (Japanese) : 950784
* 2k3 v1.06 (Japanese) : 949248
* 2k3 v1.05 (Japanese) : unknown
* -- threshold (2k3) -- : 927000
* 2k3 v1.04 (Japanese) : 913408
*/
Copy link
Contributor

@fdelapena fdelapena Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

automatic spaces to tabs seems that added an extra tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants