Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPP 2.1 messages #845

Draft
wants to merge 48 commits into
base: main
Choose a base branch
from

Clang format

49bb934
Select commit
Loading
Failed to load commit list.
Draft

OCPP 2.1 messages #845

Clang format
49bb934
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Feb 26, 2025 in 0s

95 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 8
- Added 95
           

Complexity increasing per file
==============================
- src/code_generator/common/generate_everest_types.py  4
- src/code_generator/common/utils.py  10
- src/code_generator/common/generate_cpp.py  2
         

Clones added
============
- lib/ocpp/v21/messages/NotifyWebPaymentStarted.cpp  2
- lib/ocpp/v21/messages/ReportDERControl.cpp  5
- tests/lib/ocpp/v2/smart_charging_test_utils.cpp  8
- lib/ocpp/v2/messages/PublishFirmwareStatusNotification.cpp  6
- lib/ocpp/v2/messages/NotifyMonitoringReport.cpp  5
- lib/ocpp/v2/messages/PublishFirmware.cpp  1
- lib/ocpp/v2/messages/NotifyChargingLimit.cpp  6
- lib/ocpp/v2/messages/CostUpdated.cpp  1
- tests/lib/ocpp/v2/test_device_model.cpp  6
- lib/ocpp/v2/messages/NotifyEvent.cpp  2
- lib/ocpp/v2/messages/ReportChargingProfiles.cpp  1
- lib/ocpp/v2/messages/NotifyCustomerInformation.cpp  1
- lib/ocpp/v2/messages/NotifyDisplayMessages.cpp  5
- lib/ocpp/v2/messages/GetTransactionStatus.cpp  2
- lib/ocpp/v2/messages/FirmwareStatusNotification.cpp  6
- lib/ocpp/v2/messages/NotifyReport.cpp  5
- include/ocpp/v2/ocpp_types.hpp  3
- lib/ocpp/v2/messages/LogStatusNotification.cpp  6
- lib/ocpp/v21/messages/NotifyAllowedEnergyTransfer.cpp  4
- lib/ocpp/v21/messages/ClearDERControl.cpp  10
- lib/ocpp/v21/messages/BatterySwap.cpp  2
- lib/ocpp/v21/messages/NotifyQRCodeScanned.cpp  2
- lib/ocpp/v21/messages/OpenPeriodicEventStream.cpp  10
- lib/ocpp/v21/messages/AFRRSignal.cpp  10
- lib/ocpp/v21/messages/AdjustPeriodicEventStream.cpp  10
- lib/ocpp/v21/messages/UpdateDynamicSchedule.cpp  6
- lib/ocpp/v21/messages/GetDERControl.cpp  10
- lib/ocpp/v21/messages/PullDynamicScheduleUpdate.cpp  4
- lib/ocpp/v21/messages/ClosePeriodicEventStream.cpp  1
- lib/ocpp/v21/messages/UsePriorityCharging.cpp  4
- lib/ocpp/v21/messages/NotifyDERStartStop.cpp  2
- lib/ocpp/v21/messages/SetDERControl.cpp  4
- lib/ocpp/v21/messages/VatNumberValidation.cpp  8
- lib/ocpp/v21/messages/ChangeTransactionTariff.cpp  6
- lib/ocpp/v21/messages/ClearTariffs.cpp  6
- lib/ocpp/v21/messages/GetCRL.cpp  9
- lib/ocpp/v21/messages/SetDefaultTariff.cpp  4
- lib/ocpp/v21/messages/RequestBatterySwap.cpp  12
         

Clones removed
==============
+ lib/ocpp/v2/messages/SetMonitoringLevel.cpp  -2
+ lib/ocpp/v2/messages/SendLocalList.cpp  -2
+ tests/lib/ocpp/v2/smart_charging_test_utils.hpp  -4
+ lib/ocpp/v2/messages/DeleteCertificate.cpp  -2
+ lib/ocpp/v2/messages/UpdateFirmware.cpp  -1
+ lib/ocpp/v2/messages/SetNetworkProfile.cpp  -2
+ lib/ocpp/v2/messages/SetMonitoringBase.cpp  -2
+ lib/ocpp/v2/messages/CertificateSigned.cpp  -2
+ lib/ocpp/v2/messages/GetLog.cpp  -5
+ tests/lib/ocpp/v2/test_composite_schedule.cpp  -6
+ lib/ocpp/v2/messages/BootNotification.cpp  -2
+ lib/ocpp/v2/messages/InstallCertificate.cpp  -2
+ lib/ocpp/v2/messages/ClearedChargingLimit.cpp  -3
+ lib/ocpp/v2/messages/GetCertificateStatus.cpp  -5
+ lib/ocpp/v2/messages/NotifyEVChargingNeeds.cpp  -2
+ tests/lib/ocpp/v2/test_charge_point.cpp  -5
+ lib/ocpp/v2/messages/TriggerMessage.cpp  -5
+ lib/ocpp/v2/messages/GetDisplayMessages.cpp  -2
+ lib/ocpp/v2/messages/ClearChargingProfile.cpp  -2
+ lib/ocpp/v2/messages/NotifyEVChargingSchedule.cpp  -1
+ lib/ocpp/v2/messages/GetCompositeSchedule.cpp  -6
+ lib/ocpp/v2/messages/ChangeAvailability.cpp  -5
+ lib/ocpp/v2/messages/ClearDisplayMessage.cpp  -1
+ lib/ocpp/v2/messages/GetReport.cpp  -2
+ lib/ocpp/v2/messages/GetBaseReport.cpp  -2
+ lib/ocpp/v2/messages/SetDisplayMessage.cpp  -2
+ lib/ocpp/v2/messages/CustomerInformation.cpp  -2
+ lib/ocpp/v2/messages/RequestStartTransaction.cpp  -6
+ lib/ocpp/v2/messages/UnlockConnector.cpp  -2
+ lib/ocpp/v2/messages/ReserveNow.cpp  -2
+ lib/ocpp/v2/messages/SignCertificate.cpp  -1
+ lib/ocpp/v2/messages/Get15118EVCertificate.cpp  -3
+ lib/ocpp/v2/messages/GetChargingProfiles.cpp  -2
+ lib/ocpp/v2/messages/Reset.cpp  -4
+ lib/ocpp/v2/messages/ClearCache.cpp  -2
+ lib/ocpp/v2/messages/DataTransfer.cpp  -1
+ tests/lib/ocpp/v2/functional_blocks/test_smart_charging.cpp  -8
+ lib/ocpp/v2/types.cpp  -1
+ lib/ocpp/v2/messages/RequestStopTransaction.cpp  -3
+ lib/ocpp/v2/messages/GetMonitoringReport.cpp  -2
+ lib/ocpp/v2/messages/CancelReservation.cpp  -2
+ lib/ocpp/v2/messages/GetInstalledCertificateIds.cpp  -5

See the complete overview on Codacy

Annotations

Check failure on line 1 in config/v2/device_model_migrations/3_down-variable_required.sql

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

config/v2/device_model_migrations/3_down-variable_required.sql#L1 

Expected SET ANSI_NULLS ON near top of file

Check failure on line 1 in config/v2/device_model_migrations/3_down-variable_required.sql

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

config/v2/device_model_migrations/3_down-variable_required.sql#L1 

Expected SET QUOTED_IDENTIFIER ON near top of file

Check failure on line 1 in config/v2/device_model_migrations/3_down-variable_required.sql

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

config/v2/device_model_migrations/3_down-variable_required.sql#L1 

Expected SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED near top of file

Check failure on line 1 in config/v2/device_model_migrations/3_down-variable_required.sql

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

config/v2/device_model_migrations/3_down-variable_required.sql#L1 

Object name not schema qualified

Check failure on line 1 in config/v2/device_model_migrations/3_up-variable_required.sql

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

config/v2/device_model_migrations/3_up-variable_required.sql#L1 

Expected SET ANSI_NULLS ON near top of file

Check failure on line 1 in config/v2/device_model_migrations/3_up-variable_required.sql

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

config/v2/device_model_migrations/3_up-variable_required.sql#L1 

Expected SET QUOTED_IDENTIFIER ON near top of file

Check failure on line 1 in config/v2/device_model_migrations/3_up-variable_required.sql

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

config/v2/device_model_migrations/3_up-variable_required.sql#L1 

Expected SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED near top of file

Check failure on line 1 in config/v2/device_model_migrations/3_up-variable_required.sql

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

config/v2/device_model_migrations/3_up-variable_required.sql#L1 

Object name not schema qualified

Check notice on line 471 in include/ocpp/v2/ocpp_types.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

include/ocpp/v2/ocpp_types.hpp#L471 

struct member 'CertificateStatusRequestInfo::urls' is never used.

Check notice on line 961 in include/ocpp/v2/ocpp_types.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

include/ocpp/v2/ocpp_types.hpp#L961 

struct member 'TaxRule::appliesToOverstayFee' is never used.

Check notice on line 1028 in include/ocpp/v2/ocpp_types.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

include/ocpp/v2/ocpp_types.hpp#L1028 

struct member 'AbsolutePriceSchedule::priceScheduleID' is never used.

Check notice on line 24 in include/ocpp/v21/messages/BatterySwap.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

include/ocpp/v21/messages/BatterySwap.hpp#L24 

struct member 'BatterySwapRequest::requestId' is never used.

Check notice on line 21 in include/ocpp/v21/messages/ClearDERControl.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

include/ocpp/v21/messages/ClearDERControl.hpp#L21 

struct member 'ClearDERControlRequest::isDefault' is never used.

Check notice on line 21 in include/ocpp/v21/messages/NotifyDERStartStop.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

include/ocpp/v21/messages/NotifyDERStartStop.hpp#L21 

struct member 'NotifyDERStartStopRequest::started' is never used.

Check notice on line 21 in include/ocpp/v21/messages/NotifyPeriodicEventStream.hpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

include/ocpp/v21/messages/NotifyPeriodicEventStream.hpp#L21 

struct member 'NotifyPeriodicEventStreamRequest::id' is never used.

Check warning on line 111 in src/code_generator/common/generate_everest_types.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/code_generator/common/generate_everest_types.py#L111 

Redefining built-in 'property'

Check notice on line 130 in src/code_generator/common/generate_everest_types.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/code_generator/common/generate_everest_types.py#L130 

Consider using enumerate instead of iterating with range and len

Check warning on line 150 in src/code_generator/common/generate_everest_types.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/code_generator/common/generate_everest_types.py#L150 

Redefining built-in 'property'

Check warning on line 168 in src/code_generator/common/generate_everest_types.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/code_generator/common/generate_everest_types.py#L168 

Redefining built-in 'property'

Check warning on line 210 in src/code_generator/common/generate_everest_types.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/code_generator/common/generate_everest_types.py#L210 

Redefining built-in 'property'

Check warning on line 242 in src/code_generator/common/generate_everest_types.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/code_generator/common/generate_everest_types.py#L242 

Redefining built-in 'type'

Check notice on line 21 in src/code_generator/common/utils.py

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

src/code_generator/common/utils.py#L21 

Consider using enumerate instead of iterating with range and len

Check warning on line 186 in tests/lib/ocpp/v2/smart_charging_test_utils.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

tests/lib/ocpp/v2/smart_charging_test_utils.cpp#L186 

Function parameter 'charging_schedule_period' should be passed by const reference.

Check warning on line 206 in tests/lib/ocpp/v2/smart_charging_test_utils.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

tests/lib/ocpp/v2/smart_charging_test_utils.cpp#L206 

Function parameter 'start_periods' should be passed by const reference.

Check warning on line 230 in tests/lib/ocpp/v2/smart_charging_test_utils.cpp

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

tests/lib/ocpp/v2/smart_charging_test_utils.cpp#L230 

Function parameter 'charging_schedules' should be passed by const reference.
View more details on Codacy Production