Skip to content

Fix: Error before session #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Pietfried wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix: Error before session #1743

Pietfried wants to merge 2 commits into from

Conversation

@Pietfried
Copy link
Contributor

@Pietfried Pietfried commented Jan 15, 2026

Describe your changes

Adds error handling to ProbeModule and implements smoke tests for basic charging sessions (PWM AC, ISO 15118 AC/DC). Includes error blocking in EvseManager's authentication state to prevent charging when errors are active.

  • Add error raise/clear/subscribe methods to ProbeModule
  • Add smoke tests for charging sessions and error handling
  • Add fatal error check in EvseManager WaitingForAuthentication state
  • Remove obsolete basic_charging_tests.py

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@Pietfried
fix(EvseManager): Prevent start of a Session if error is active and a…
b94f291 
…llowing HLC module to signaling error if HLC session is initiated.

Signed-off-by: Piet Gömpel <[email protected]>
@Pietfried
test(core): Add smoke tests for PWM and ISO15118 AC and DC charging i…
bafad06 
…ncluding one test case that verifies that no session starts when an error is active

Signed-off-by: Piet Gömpel <[email protected]>
@Pietfried Pietfried linked an issue Jan 15, 2026 that may be closed by this pull request
DC charging starts even if errors were raised and the EVSE manager is inoperative #1738
Open
@Pietfried Pietfried mentioned this pull request Jan 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corneliusclaussen corneliusclaussen Awaiting requested review from corneliusclaussen corneliusclaussen will be requested when the pull request is marked ready for review corneliusclaussen is a code owner

@SebaLukas SebaLukas Awaiting requested review from SebaLukas SebaLukas will be requested when the pull request is marked ready for review SebaLukas is a code owner

@hikinggrass hikinggrass Awaiting requested review from hikinggrass hikinggrass will be requested when the pull request is marked ready for review hikinggrass is a code owner

@mlitre mlitre Awaiting requested review from mlitre mlitre will be requested when the pull request is marked ready for review mlitre is a code owner

@andistorm andistorm Awaiting requested review from andistorm andistorm will be requested when the pull request is marked ready for review andistorm is a code owner

@djchhp djchhp Awaiting requested review from djchhp djchhp will be requested when the pull request is marked ready for review djchhp is a code owner

@james-ctc james-ctc Awaiting requested review from james-ctc james-ctc will be requested when the pull request is marked ready for review james-ctc is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DC charging starts even if errors were raised and the EVSE manager is inoperative

2 participants

@Pietfried