libiso15118: d2: Service discovery flow messages #1739
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 15, 2026 07:17
Signed-off-by: Kacper Dalach <[email protected]>
Signed-off-by: Kacper Dalach <[email protected]>
Signed-off-by: Kacper Dalach <[email protected]>
std::variant is used instead of a bunch of std::optional. This is to make the usage of Parameter more clear. Signed-off-by: Kacper Dalach <[email protected]>
Dalachowsky
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass,
james-ctc and
mlitre
as code owners
SebaLukas
changed the title
Author
|
@SebaLukas please take a look at the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR introduces following -2 messages:
Issue ticket number and link
#1720, #1721, #1722
Checklist before requesting a review