[OCPP] Fix incorrect composite schedule when duration is zero #1716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An incorrect composite schedule was generated when the duration was 0. The fallback vales were used rather than values from the active schedule. Additional check added to ensure start time is not greater than end time. Signed-off-by: James Chapman <[email protected]>
james-ctc
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass and
mlitre
as code owners
Pietfried
previously approved these changes
Jan 16, 2026
| DateTime current = now; | ||
|
|
||
| while (current < end) { | ||
| // run calculation at least once especially where current < end |
Contributor
There was a problem hiding this comment.
Suggested change
| // run calculation at least once especially where current < end | |
| // run calculation at least once, especially when current >= end |
| DateTime current = now; | ||
|
|
||
| while (current < end) { | ||
| // run calculation at least once especially where current < end |
Contributor
There was a problem hiding this comment.
Suggested change
| // run calculation at least once especially where current < end | |
| // run calculation at least once, especially when current >= end |
Signed-off-by: James Chapman <[email protected]>
Pietfried
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updates to composite schedule to address issues identified in libocpp issue 1169
An incorrect composite schedule was generated when the duration was 0. The fallback vales were used rather than values from the active schedule.
Additional check added to ensure start time is not greater than end time.
Issue ticket number and link
EVerest/libocpp#1169
Checklist before requesting a review