FIX handling of CAN device interface names #1715
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check the length of CAN device interface names before copying them to the Linux internal strcutures. This avoids a potential buffer overflow error. Signed-off-by: Jan Christoph Habig <[email protected]>
djchhp
requested review from
Pietfried,
cburandt,
corneliusclaussen,
florinmihut,
hikinggrass and
james-ctc
as code owners
lategoodbye
reviewed
Jan 14, 2026
| // The name can occupy the fill buffer. If it does not, nulltermination is necessary | ||
| // Since most Linux systems enforce 15 chars as limit plus 1 for nulltermination | ||
| // we do the same thing here. | ||
| if(can_device.size() >= IFNAMSIZ){ |
Contributor
There was a problem hiding this comment.
Just a nit regarding style. Please place a space after the "if".
fix style Signed-off-by: Jan <[email protected]>
hikinggrass
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the length of CAN device interface names before copying them to the Linux internal strcutures. This avoids a potential buffer overflow error.
Describe your changes
Issue ticket number and link
Checklist before requesting a review