[OCPP 1.6] new interface to support OCPP 1.6 obtaining configuration from V2 data model #1714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChargePointConfiguration now inherits from ChargePointConfigurationInterface. The ChargePointConfigurationInterface implementation can be selected by the OCPP module in the ChargePoint constructor. Signed-off-by: James Chapman <[email protected]>
Moved from DeviceModelStorageInterface to DeviceModelInterface Signed-off-by: James Chapman <[email protected]>
james-ctc
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass and
mlitre
as code owners
Signed-off-by: James Chapman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
OCPP 1.6 obtains configuration from JSON files.
This change creates a ChargePointConfigurationInterface that enables OCPP1.6 to either use the existing JSON files via ChargePointConfiguration or V2 device model (and database) via ChargePointConfigurationDeviceModel
Unit tests have been added to ensure that the same result occurs regardless of which implementation is used.
In addition there is a common ChargePointConfigurationBase base class where shared functionality between the implementations is located. This ensures where possible that the two implementations remain consistent.
Issue ticket number and link
Checklist before requesting a review