Fix station not sending data anymore after 1 second send timeout #1713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Emmers <[email protected]>
marcemmers
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
hikinggrass,
james-ctc and
mlitre
as code owners
Signed-off-by: Marc Emmers <[email protected]>
Contributor
|
Hi @marcemmers , looks like some libocpp unit tests failed. Were the tests passing for you locally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When a websocket transmission took more than 1 second it would timeout and cause the message queue to pause. It would never come back from that until a websocket was connected again.
This timeout of 1 second was fixed and is now based on the message timeout as configured in each network profile, making it more flexible to configure the timeout per connectivity type for example.
Also the message queue is not paused any longer when a message fails. If the socket is closed for whatever reason the websocket ping should timeout and close the socket.
Issue ticket number and link
Checklist before requesting a review