EvseV2G: handle DC charging renegotiation correctly #1691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensure current demand is stopped for DC charging during renegotiation Signed-off-by: Fabian Hartung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I noticed that when the renegotiation process is started by the EV, no notification is sent to the EvseManager that the DC CurrentDemand loop has been stopped. Currently, the EvseManager remains in the “Charging” state (at least as long as no CP state transition to B has occurred). In AC, charging is still permitted during the renegotiation process, so it is not necessary to send a notification. It's only a draft because I haven't been able to test my changes yet, and this case is not currently covered in the SIL.
Issue ticket number and link
--
Checklist before requesting a review