refactor(OCPP): Move ConnectivityManager to common namespace #1689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Move ConnectivityManager to common namespace for reuse across OCPP versions * Refactor constructor to accept logging and message callbacks via setters instead of constructor parameters * Add ChargePoint constructor accepting shared ConnectivityManagerInterface for external injection * Add validation that MessageLogging instance is provided to websocket at construction Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
force-pushed
the
refactor/ocpp/connectivity-manager
branch
from
687f18a to
93facc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Move ConnectivityManager from v2 to common namespace:
Issue ticket number and link
Checklist before requesting a review