Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove json config view/download #231

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

12fab4
Copy link
Collaborator

@12fab4 12fab4 commented Feb 26, 2025

this removes the display and download option for configs in json format as yaml is way more human readable & editable

completes #225

Copy link
Collaborator Author

12fab4 commented Feb 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • queue - adds this PR to the back of the merge queue
  • skip-queue - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@12fab4 12fab4 mentioned this pull request Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.09% 11 / 11069
🔵 Statements 0.09% 11 / 11069
🔵 Functions 73.8% 31 / 42
🔵 Branches 75.55% 34 / 45
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/ConfigPreview.vue 0% 0% 0% 0%
Generated in workflow #673 for commit d1176cb by the Vitest Coverage Report Action

@12fab4 12fab4 requested a review from lukas-mertens February 26, 2025 10:56
@lukas-mertens lukas-mertens changed the base branch from better-linting to graphite-base/231 February 26, 2025 11:27
@lukas-mertens lukas-mertens force-pushed the 02-26-fix_remove_json_config_view_download branch from cfdef54 to 7172770 Compare February 26, 2025 11:28
@lukas-mertens lukas-mertens changed the base branch from graphite-base/231 to main February 26, 2025 11:28
@lukas-mertens lukas-mertens force-pushed the 02-26-fix_remove_json_config_view_download branch from 7172770 to c79dac2 Compare February 26, 2025 11:28
@12fab4 12fab4 marked this pull request as ready for review February 26, 2025 15:23
Copy link
Collaborator

Sign the commit, besides that, looks good!

Copy link
Contributor

graphite-app bot commented Feb 27, 2025

Merge activity

  • Feb 27, 5:25 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 27, 5:26 AM EST: Graphite rebased this pull request as part of a merge.
  • Feb 27, 5:27 AM EST: A user merged this pull request with the Graphite merge queue.

@12fab4 12fab4 force-pushed the 02-26-fix_remove_json_config_view_download branch from c79dac2 to d1176cb Compare February 27, 2025 10:26
@graphite-app graphite-app bot merged commit 621928c into main Feb 27, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants