Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(EVBackendConnection): access url property properly #198

Conversation

lukas-mertens
Copy link
Collaborator

@lukas-mertens lukas-mertens commented Oct 12, 2024

This pull request adds getter methods for the connection property in the EVBackendClient class and the url property in the EVBackendConnection class. It also updates the MainPanel.vue file to use the new getter method for accessing the connection URL.

It is necessary for strict typesafety

@lukas-mertens lukas-mertens marked this pull request as ready for review October 12, 2024 10:30
@lukas-mertens lukas-mertens changed the base branch from renovate/vue-tsc-2.x to graphite-base/198 October 12, 2024 10:37
@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from 393ac65 to 51007ea Compare October 12, 2024 10:37
@lukas-mertens lukas-mertens changed the base branch from graphite-base/198 to main October 12, 2024 10:38
@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from 51007ea to 25ed74c Compare October 12, 2024 10:38
Copy link

github-actions bot commented Oct 12, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.14% 18 / 12212
🔵 Statements 0.14% 18 / 12212
🔵 Functions 2.5% 1 / 40
🔵 Branches 9.3% 4 / 43
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/modules/evbc/client.ts 0% 0% 0% 0%
src/modules/evbc/connection.ts 0% 0% 0% 0%
src/pages/MainPanel.vue 0% 0% 0% 0%
Generated in workflow #455 for commit 5f5ec2d by the Vitest Coverage Report Action

@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from 25ed74c to 6da89ae Compare October 12, 2024 10:51
@lukas-mertens lukas-mertens changed the base branch from main to 10-12-ci_execute_on_prs_against_all_branches_for_graphite_compatibility October 12, 2024 10:51
@lukas-mertens lukas-mertens force-pushed the 10-12-ci_execute_on_prs_against_all_branches_for_graphite_compatibility branch from 5998275 to 7ca92fa Compare October 12, 2024 10:53
@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from 6da89ae to 8061e49 Compare October 12, 2024 10:54
@lukas-mertens lukas-mertens force-pushed the 10-12-ci_execute_on_prs_against_all_branches_for_graphite_compatibility branch from 7ca92fa to 7c16eaa Compare October 12, 2024 11:29
@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from 8061e49 to 5dec3df Compare October 12, 2024 11:29
@lukas-mertens lukas-mertens force-pushed the 10-12-ci_execute_on_prs_against_all_branches_for_graphite_compatibility branch from 7c16eaa to 2cec502 Compare October 12, 2024 12:18
@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from 5dec3df to a21a87d Compare October 12, 2024 12:19
@lukas-mertens lukas-mertens changed the base branch from 10-12-ci_execute_on_prs_against_all_branches_for_graphite_compatibility to 10-12-build_vite_enable_minify_on_build October 12, 2024 12:19
@lukas-mertens lukas-mertens force-pushed the 10-12-build_vite_enable_minify_on_build branch from a4f5bd6 to efb4225 Compare October 12, 2024 12:21
@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from a21a87d to 13b3d93 Compare October 12, 2024 12:21
@lukas-mertens lukas-mertens force-pushed the 10-12-build_vite_enable_minify_on_build branch from efb4225 to 977a67d Compare October 14, 2024 13:19
@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from 13b3d93 to 39b15b4 Compare October 14, 2024 13:20
@lukas-mertens lukas-mertens force-pushed the 10-12-build_vite_enable_minify_on_build branch from 977a67d to f549295 Compare October 14, 2024 13:25
@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from 39b15b4 to 6ad8326 Compare October 14, 2024 13:25
@lukas-mertens lukas-mertens force-pushed the 10-12-build_vite_enable_minify_on_build branch from f549295 to 86480ce Compare October 15, 2024 08:17
@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from 6ad8326 to ff1af40 Compare October 15, 2024 08:17
@lukas-mertens lukas-mertens changed the base branch from 10-12-build_vite_enable_minify_on_build to main October 15, 2024 08:21
@lukas-mertens lukas-mertens force-pushed the 10-12-refactor_evbackendconnection_access_url_property_properly branch from ff1af40 to 5f5ec2d Compare October 15, 2024 08:21
@lukas-mertens lukas-mertens merged commit 60820da into main Oct 15, 2024
10 checks passed
Copy link
Collaborator Author

Merge activity

  • Oct 15, 4:25 AM EDT: A user merged this pull request with Graphite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants