Several improvements to SecondsFrame #514
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Frame to layout "Nero" (can be used to remodel a clock from the 2013 AVR based project)
Add support for Nero layout with frame
Add support for Nero Frame mode
Wrong location
- Second Frame can have 200 LEDs
|
Hey @Vrumfondel, the Clang format linter got some errors :-) maybe you could address them ? Cheers |
|
Done |
|
Hey, not quite yet, calling is nasty but very useful. I will merge it on the weekend and will correct it. Cheers |
|
tnx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added clockstyle "neroFrame"
SecondsFrame can have more than 64 LEDs (currently up to 200)
SecondsFrame offset is calculated from total number of SecondsFrame LEDs