Adding variable checks - #16
Merged
Merged
Conversation
The 1-D branch of check_bounds_shape required shape (N, 2), rejecting FESOM2 / ICON / MPAS native output where lat(nod2) carries polygon- vertex bounds lat_bnds(nod2, m). CF 1.11 §7.1 permits both layouts on 1-D coords. Relax to bvar.shape[1] >= 2; update the failure message.
Addresses @sol1105's review on PR ESGF#38. The 1-D branch now uses the parent dimension as the discriminator: another 1-D coord sharing the same dimension and declaring bounds means unstructured topology (allow polygon vertices), otherwise it is a classic 1-D coord on its own dimension and only interval bounds (N, 2) are valid. Behaviour: - FESOM2 / ICON / MPAS unstructured (lat(ncell) + lon(ncell), both with bounds): sibling clause triggers, polygon bounds (N, m>=2) accepted. - Regular grid lat(lat) with malformed lat_bnds(lat, 3): no sibling on dim 'lat', strict branch applies, flagged. - 2-D curvilinear: unchanged, handled by the existing ndim >= 2 branch. - Lone 1-D coord with no companion on its dim: strict branch. Conservative default that matches historic behaviour.
…-bounds Accept polygon-vertex bounds in VAR004 shape check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new variable checks from QC Checks Table that are not covered by the CF Conventions Checker.