-
Notifications
You must be signed in to change notification settings - Fork 207
update compsets to match cesm3 spreadsheet compsets #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cesm3.0-alphabranch
Are you sure you want to change the base?
update compsets to match cesm3 spreadsheet compsets #320
Conversation
<lname>HISTE_CAM70%MT%CT4S_CLM60%BGC-CROP_CICE_MOM6_MOSART_DGLC%NOEVOLVE_WW3</lname> | ||
</compset> | ||
<compset> | ||
<alias>BHISTEM</alias> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this alias be BHISTE_MTt4s instead of the "Alternate Alias" BHISTEM?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both aliases are allowed, BHISTE_MTt4s is at line 108.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Twice the aliases, twice the fun.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed all of the long compset names in the PR are just using MOM6. The spreadsheet shows MOM6%MARBL-BIO. I'm guessing you didn't add MARBL-BIO because it's not ready yet.
@fischer-ncar Right - we can't add MARBL-BIO yet. |
I'll need to update the test list for the new compset aliases. |
@brian-eaton pointed out that %HT, and %CT4MA don't exists in CAM. |
@fvitt Will you be adding %HT and %CT4Ma to cam before the next tag? |
As far as I am concerned, I can merge and tag this anytime now. @cacraigucar coordinates the cam tagging... |
Spreadsheet
Description of changes
Specific notes
Contributors other than yourself, if any:
Fixes: [Github issue #s] And brief description of each issue.
User interface changes?: [ No/Yes ]
[ If yes, describe what changed, and steps taken to ensure backward compatibility ]
Testing performed (automated tests and/or manual tests):