fix(django): migrating to Django 5 #583
Conversation
Small changes to models (indexes) and some other places (timezones, and CommandParser)
Removing `six` utils Using canonical imports Removal of deprecated funcitons in multiparttools
Using venv to install packages in
jankovicgd
left a comment
jankovicgd
left a comment
There was a problem hiding this comment.
Easy mental and challenging physical (lotsa clicks) review lol. I think if you confirmed it all works, we tag and I try to bring it into VS and we resume there if anything is wonky
There was a problem hiding this comment.
Why did you go for venv? I've usually read to avoid this unless multi stage builds are used, but maybe it is also okay to avoid clashes with "system" dependencies
There was a problem hiding this comment.
Yes, that was the reason. With the Python version used in Ubuntu 24.04 it was no longer possible to install user packages next to system ones without a venv.
There was a problem hiding this comment.
is this just https://docs.python.org/3/library/datetime.html#datetime.datetime.fromisoformat or is there more to it?
There was a problem hiding this comment.
I think this predates fromisoformat by some years. I think we could now use fromisoformat with the additional Z suffix check. I'll look into it.
There was a problem hiding this comment.
With 73c4c86 I got rid of dateutil. When the tests pass I think we are good.
Closes #581
Small changes to models (indexes) and some other places (timezones, and CommandParser)
Moving towards Python 3:
sixutilsUsing Ubuntu 24.04 as base image, because Django did no longer work with the systems version of spatialite
General linting fixes